DESCRIPTION

Bug 482024 - ExpandableComposite layout issues DO NOT SUBMIT

Bug 368861 - ExpandableComposite failed to compute right wrapped client
size 

- removed all special cases in regards to guessing about wrapping on
client controls and let control calculate its own size based on hints
- refactored code that same calculations are used when calculating size
and doing layout, otherwise its duplicated in two spots leading to some
nasty issues
- better heuristics when calculating proportions of text client and text
label controls
- fixed bug in SizeCache where it won't let control calculate size with
given hint because it calculates wrong minimumWidth. Removed lots of
special cases in SizeCache leaving so it actually cache the size rather
then guess it. Added lots of tests for it

testing done:
- run existing junits and wrote bunch more, 
- current code coverage for ExpandableComposite is 72%
- manual tested bunch of flag combinations
- test running eclipse sdk and using PDE editors that use forms heavily 
(plugin manifest and target definition editor) seems to be ok 
(linux ubuntu and windows 8)

[do not submit, I have not fixed issues raised in the review]

Change-Id: I8fdeb70d39d3c762a297f476356257ee91ae666d
Signed-off-by: Ishaan Salas xxx@xxx.xxx

COMMENTS

author: Julian Foster
date: 2016-01-26 03:58:38.000000000

Uploaded patch set 18.

-------------------------------------
author: Brenden Conley
date: 2016-01-26 03:58:43.000000000

Patch Set 18:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8094/

-------------------------------------
author: Brenden Conley
date: 2016-01-26 04:23:23.000000000

Patch Set 18: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8094/ : SUCCESS

-------------------------------------
author: Julian Foster
date: 2016-01-27 00:33:49.000000000

Patch Set 18:

After removed this block of code that was doing weird stuff in the begging of SizeCache more tests start passing, I removed all "uncomment this when bug is fixed" stuff in tests. Tests were not passing on Hyperlink which is custom form control which did not follow any sort of conventions about computeSize, so I fixed that too. Main problem with SizeCache it will return hints more less verbatim if both are set, which is not the same as control returns. Control can return minimum or maximum in one of the axes, instead of hint. Should I change it to cache it too instead of guessing?

-------------------------------------
author: Gerrit Code Review
date: 2017-05-04 20:04:27.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
