DESCRIPTION

Bug 411578 - Selecting workspace with one click

The "Recent Workspaces"-Composite provides a quicker way to select or
delete a specific workspace

Change-Id: Ifce2dbc69d60db865c4ef43ffbf043b0122a067d
Signed-off-by: Kylan Friedman xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2015-12-01 08:50:56.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7616/

-------------------------------------
author: Zaid Mosley
date: 2015-12-01 09:08:19.000000000

Patch Set 7: Code-Review-1

(7 comments)

Looks good but needs adjustments.

Line:84, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceData.java -> not a good name. I suggest to call it: showRecentWorkspaces. Composite is an implementation detail.

Line:177, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceData.java -> isShowRecentWorkspaces

Line:209, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceData.java -> setShowRecentWorkspaces

Line:198, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDE.java -> I would call this "SHOW_RECENT_WORKSPACES" and define it after the definition of SHOW_WORKSPACE_SELECTION_DIALOG.

Line:252, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceDialog.java -> better name: removeWorkspaceFromLauncher

Line:368, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceDialog.java -> \\ works only for Windows. You should use java.io.File.separator or System.getProperty("file.separator")

Line:962, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/messages.properties -> I think "Forget" is a bad name. I suggest to call this: "Remove from launcher selection" or "Remove from selection"

-------------------------------------
author: Brenden Conley
date: 2015-12-01 11:26:52.000000000

Patch Set 7: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7616/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2015-12-14 11:12:43.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
