DESCRIPTION

Bug 478399 - NPE when fragment without parent ID is merged

Added validation of fragment before it gets merged

Change-Id: I9ef51203b42852d20ed1ea1f94ac8edd5a86e28c
Signed-off-by: Emma Robertson xxx@xxx.xxx


COMMENTS

author: Zaid Mosley
date: 2015-10-23 19:19:26.000000000

Patch Set 2: Code-Review+1 Verified+1

Looks good to me. Maybe also add a test for it?

-------------------------------------
author: Brenden Conley
date: 2015-10-23 19:28:15.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7160/

-------------------------------------
author: Brenden Conley
date: 2015-10-23 19:44:55.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7160/ : SUCCESS

-------------------------------------
author: Emma Robertson
date: 2015-10-26 07:04:00.000000000

Patch Set 2: Code-Review+2

Tests would be good, but would require some refactoring, as the current class is not testable at all. As we plan to fix another BR in the ModelAssembler, I created a BR for adding tests:
Bug 480610

-------------------------------------
author: Gerrit Code Review
date: 2015-10-26 07:04:06.000000000

Change has been successfully merged into the git repository by Emma Robertson

-------------------------------------
