DESCRIPTION

Bug 478333 - Adopt Adapters.getAdapter in org.eclipse.ui.internal

Change-Id: Iff37a466c163294223e70ef5266a73ba793f27d7
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Zaid Mosley
date: 2015-10-03 09:43:20.000000000

Patch Set 3: Code-Review-1

(4 comments)

Line:341, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java -> Inline method, only called one.

Line:354, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java -> Inline method, only called one.

Line:500, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/SaveableHelper.java -> I think this instanceof check can be deleted, is also done via getAdapter

Line:511, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/SaveableHelper.java -> I think this instanceof check can be deleted, is also done via getAdapter

-------------------------------------
author: Brenden Conley
date: 2015-10-03 10:23:24.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6908/

-------------------------------------
author: Brenden Conley
date: 2015-10-03 10:37:44.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6908/ : SUCCESS

-------------------------------------
author: Kelly Potter
date: 2015-10-05 14:40:01.000000000

Patch Set 3:

(4 comments)

Line:341, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java -> Done

Line:354, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/ShowInMenu.java -> Done

Line:500, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/SaveableHelper.java -> Done

Line:511, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/SaveableHelper.java -> This one can't be done by getAdapter. It handles the (really weird) case where someone returns an adapter registered for ISaveablePart that implements ISaveablePart2.

-------------------------------------
author: Gerrit Code Review
date: 2015-10-05 16:27:00.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
