DESCRIPTION

Bug 478833 - Adopt Adapters.getAdapter in org.eclipse.ui.wizards

Change-Id: Ic1cb768755d0f1972bfe3b24b3fc435b68b41255
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Kelly Potter
date: 2015-09-28 02:13:55.000000000

Uploaded patch set 1.

-------------------------------------
author: Brock Pruitt
date: 2015-09-28 03:41:47.000000000

Patch Set 1:

(3 comments)

Line:436, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> This code looks bogus to me. No resource should adapt to IFile unless it is IFile, but whatever, garbage in - garbage out.

Line:87, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewResourceWizard.java -> Why this change?

Line:94, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemExportWizard.java -> Shouldn't this be currentEditor.getEditorInput() instead of currentEditor?

-------------------------------------
author: Brenden Conley
date: 2015-09-28 03:59:24.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6772/

-------------------------------------
author: Kelly Potter
date: 2015-09-28 04:11:18.000000000

Patch Set 1:

(3 comments)

Line:436, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> Yeah, it does look weird. Should we bother investigating further?

Line:87, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewResourceWizard.java -> It fixes a warning.

Line:94, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemExportWizard.java -> It should. Nice catch. Done.

-------------------------------------
author: Brock Pruitt
date: 2015-09-28 04:28:44.000000000

Patch Set 1:

(2 comments)

Line:436, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> Maybe put a TODO comment for future generations.

Line:87, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewResourceWizard.java -> Just curious. What was the warning?

-------------------------------------
author: Brenden Conley
date: 2015-09-28 04:58:32.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6772/ : SUCCESS

-------------------------------------
author: Kelly Potter
date: 2015-09-29 05:24:31.000000000

Patch Set 1:

(3 comments)

Line:436, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> Done

Line:436, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> Done

Line:87, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewResourceWizard.java -> It warned because it masked the member variable "workLeon Ochoach".

-------------------------------------
author: Brock Pruitt
date: 2015-09-29 18:48:14.000000000

Patch Set 1:

(1 comment)

Line:87, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/newresource/BasicNewResourceWizard.java -> We should probably change the compiler preferences to bring them in line with other plugins.

-------------------------------------
author: Gerrit Code Review
date: 2015-09-30 03:08:00.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
