DESCRIPTION

Bug 478833 - Adopt Adapters.getAdapter in org.eclipse.ui.internal.views.markers

Change-Id: I2f2d33632321795f776737d09643354cb0848abe
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Kelly Potter
date: 2015-09-28 02:13:35.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-09-28 03:29:18.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6770/

-------------------------------------
author: Brenden Conley
date: 2015-09-28 03:44:42.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6770/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2015-09-28 04:26:14.000000000

Patch Set 1:

(1 comment)

Line:506, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ExtendedMarkersView.java -> Do we really need to call getAdapter for our own class?

-------------------------------------
author: Kelly Potter
date: 2015-09-28 04:42:12.000000000

Patch Set 1:

(1 comment)

Line:506, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ExtendedMarkersView.java -> No, not really. It would be more efficient to reuse whatever goes on inside getAdapter when it provides adapters of this type.

-------------------------------------
author: Kelly Potter
date: 2015-09-29 05:18:27.000000000

Patch Set 1:

(1 comment)

Line:506, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/ExtendedMarkersView.java -> Actually, in this case it's necessary. The adapter in question is a declarative one and is not hardcoded inside getAdapter.

-------------------------------------
author: Gerrit Code Review
date: 2015-09-30 03:02:18.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
