DESCRIPTION

Bug 478456 - Implement the SideEffect class

Change-Id: I22820059a2aaaf8e11647d8de37b9edc61c55fe1


COMMENTS

author: Kelly Potter
date: 2015-09-26 04:33:02.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-09-26 04:33:09.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6754/

-------------------------------------
author: Brenden Conley
date: 2015-09-26 04:42:15.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6754/ : FAILURE

-------------------------------------
author: Brock Pruitt
date: 2015-09-26 05:11:03.000000000

Patch Set 3:

(21 comments)

Line:2, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> Isn't this a new file?

Line:24, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> Please add a brief description.

Line:25, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> Unnecessary blank line.

Line:28, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> Unnecessary blank line.

Line:30, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> Redundant initialization.

Line:40, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> Why not <>?

Line:279, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> it self -> itself

Line:280, tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/SideEffectTest.java -> eventually -> will eventually

Line:1, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> Copyright header, please.

Line:10, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> Should this be xxx@xxx.xxx TrackedGetter}?

Line:12, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> I have trouble parsing this.

Line:68, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> xxx@xxx.xxx #toRun}

Line:71, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> xxx@xxx.xxx #markDirty}

Line:161, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> It will then run it -> The runnable will then run

Line:163, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> given -> returned

Line:199, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> any additional times -> anymore

Line:276, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> Rewrap comments.

Line:318, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> on -> one

Line:319, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> xxx@xxx.xxx #markDirty}

Line:1, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/IDisposable.java -> Copyright header, please.

Line:8, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/IDisposable.java -> If we follow this pattern, we end up with many IDisposable interfaces all over the place. Would it make sense to create one in org.eclipse.core.runtime to avoid further proliferation?

-------------------------------------
author: Zaid Mosley
date: 2015-09-28 14:36:37.000000000

Patch Set 4: Patch Set 3 was rebased

-------------------------------------
author: Gerrit Code Review
date: 2015-11-12 01:43:47.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
