DESCRIPTION

Bug 478456 - Implement the SideEffect class

Change-Id: I22820059a2aaaf8e11647d8de37b9edc61c55fe1
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Kelly Potter
date: 2015-11-11 20:25:45.000000000

Uploaded patch set 13.

-------------------------------------
author: Brock Pruitt
date: 2015-11-11 20:34:55.000000000

Patch Set 13:

(3 comments)

Line:48, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ISideEffect.java -> garbace -> garbage

Line:69, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> Move the nested class to the beginning or the end of the containing class.

Line:229, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> This method should probably be package protected. Otherwise it needs Javadoc.

-------------------------------------
author: Brenden Conley
date: 2015-11-11 20:38:34.000000000

Patch Set 13:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7371/

-------------------------------------
author: Kelly Potter
date: 2015-11-11 20:52:57.000000000

Patch Set 13:

(2 comments)

Line:69, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> Done.

Line:229, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/SideEffect.java -> The whole class is package protected, so I don't think it matters... but I'll change it anyway.

-------------------------------------
author: Kelly Potter
date: 2015-11-11 20:54:10.000000000

Patch Set 13:

(1 comment)

Line:48, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ISideEffect.java -> Done

-------------------------------------
author: Brenden Conley
date: 2015-11-11 20:54:35.000000000

Patch Set 13: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7371/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2015-11-12 01:43:47.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
