DESCRIPTION

Bug 455281 - [Model] ModelServiceImpl.findElements(*) does not filter parts from outside perspective

When processing the children of an MWindow containing a primary
MPerspectiveStack, and not instructed to consider elements outside
of the perspectives, then restrict the search to within that primary
perspective stack.

Update UIAllTests to require Java8 and JUnit4

Change-Id: I866c3c09215606b42918078f9d25f9c273d75379


COMMENTS

author: Teagan Marsh
date: 2015-08-20 21:15:20.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2015-08-20 21:21:30.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6379/

-------------------------------------
author: Zaid Mosley
date: 2015-08-20 21:33:27.000000000

Patch Set 2:

(3 comments)

Line:45, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServicePerspectiveFindTests.java -> Why extends TestCase? If you add a JUnit4 test you do not need to extend it.

Line:159, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServicePerspectiveFindTests.java -> AFAIK (http://www.vogella.com/tutorials/JUnit/article.html#junitadvanced_parameterizedtests) a parameterized test is only allowed to contain one test method.

Line:25, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/StartupTestSuite.java -> Alternatively you could convert the whole test suite to JUnit4. The Junit4 runner can execute JUnit3 tests, if you run JUnit3 test suites, see https://wiki.eclipse.org/Eclipse/Testing/JUnit4_Changes#JUnit-4-style_test_suites

-------------------------------------
author: Brenden Conley
date: 2015-08-20 21:41:27.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6379/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-08-21 01:26:34.000000000

Patch Set 2:

(3 comments)

Thanks for the quick review, Lars.  I'll address these issues in the next patch.

Line:45, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServicePerspectiveFindTests.java -> Oops! Good catch.

Line:159, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServicePerspectiveFindTests.java -> Doesn't seem to be a documented limitation: the javadocs for Parameterized talks of "test methods".  And it works fine in practice.

Line:25, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/StartupTestSuite.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2015-08-21 18:21:29.000000000

Change has been successfully merged into the git repository by Teagan Marsh

-------------------------------------
