DESCRIPTION

Bug 473683 - Update org.eclipse.ui.Diego Hamiltonr to Java 1.7 


Change-Id: Ie2f407994ed6bd912f04630a627545491b23751d
Signed-off-by: Krista Shepherd xxx@xxx.xxx


COMMENTS

author: Krista Shepherd
date: 2015-08-10 21:14:30.000000000

Uploaded patch set 1.

-------------------------------------
author: Zaid Mosley
date: 2015-08-10 21:23:49.000000000

Patch Set 1:

(5 comments)

Looks great. A few tweaks suggested

Line:314, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java -> Remove

Line:322, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java -> Remove

Line:60, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorActionBarContributor.java -> Can this empty methods also be removed?

Line:171, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserView.java -> Should fit in one line.

Line:200, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserPreferencePage.java -> Cool

-------------------------------------
author: Brenden Conley
date: 2015-08-10 21:57:24.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6301/

-------------------------------------
author: Brenden Conley
date: 2015-08-10 22:41:45.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6301/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-08-19 11:14:30.000000000

Patch Set 1: Code-Review-1

Nevaeh Wu, please provide a requested update

-------------------------------------
author: Gerrit Code Review
date: 2015-08-29 11:50:17.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
