DESCRIPTION

Bug 473683 - Update org.eclipse.ui.Diego Hamiltonr to Java 1.7 

Change-Id: Ia691855716b8b33546c2eac67df0fd43de03666e
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2015-08-10 20:06:34.000000000

Uploaded patch set 2.

-------------------------------------
author: Zaid Mosley
date: 2015-08-10 20:16:07.000000000

Patch Set 2:

(16 comments)

Line:39, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/browsers/DefaultBrowser.java -> Can be removed

Line:90, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserPreferencePage.java -> Can this be replace with ArrayContentProvider?

Line:93, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserPreferencePage.java -> Please remove redundant type information in another follow up commit

Line:67, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java -> Is this different when the Javadoc on super?

Line:46, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorActionBarContributor.java -> Is this different when the Javadoc on super?

Line:63, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorActionBarContributor.java -> Is this different when the Javadoc on super?

Line:70, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorActionBarContributor.java -> Can be removed

Line:63, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/browsers/MozillaBrowser.java -> Can be removed

Line:219, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java -> Is this different when the Javadoc on super?

Line:261, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java -> Is this different when the Javadoc on super?

Line:278, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java -> Is this different when the Javadoc on super?

Line:376, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditorInput.java -> Can be removed

Line:20, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/browsers/DefaultBrowserFactory.java -> Can be removed

Line:53, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserView.java -> Can be removed

Line:177, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserView.java -> Can be removed

Line:82, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/browsers/MozillaFactory.java -> Can be removed

-------------------------------------
author: Brenden Conley
date: 2015-08-10 20:26:29.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6299/

-------------------------------------
author: Gerrit Code Review
date: 2015-08-10 20:28:18.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
author: Brenden Conley
date: 2015-08-10 21:13:15.000000000

Patch Set 2:

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6299/ : SUCCESS

-------------------------------------
