DESCRIPTION

Bug 474273 - Use Job.create in Platform code

Change-Id: Id7d76937536afa073a25facc826d140d25586c46
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2015-08-05 19:34:09.000000000

Uploaded patch set 5.

-------------------------------------
author: Brock Pruitt
date: 2015-08-05 22:14:31.000000000

Patch Set 5:

(2 comments)

Line:1085, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceInfoPage.java -> This use case would be better served by Job.create(String name, final ICoreRunnable runnable) that is being introduced in https://git.eclipse.org/r/#/c/53273.

Line:103, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/ShowInSystemExplorerHandler.java -> It would be cleaner to use IOException | InterruptedException

-------------------------------------
author: Brenden Conley
date: 2015-08-06 00:17:56.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6277/

-------------------------------------
author: Brenden Conley
date: 2015-08-06 00:56:50.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6277/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2015-08-06 04:01:07.000000000

Patch Set 5: Code-Review+1

-------------------------------------
author: Zaid Mosley
date: 2015-08-06 05:51:23.000000000

Patch Set 5:

(2 comments)

Line:1085, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceInfoPage.java -> Yes, once the other change is in, we should adjust this code.

Line:103, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/ShowInSystemExplorerHandler.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2015-08-08 07:55:10.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
