DESCRIPTION

Bug 465893 xxx@xxx.xxx not evaluated for rendering of MDirectToolItems

Change-Id: Iad733d122e52a2ab2800f23708cbfc36150d65de
Signed-off-by: Myah Faulkner xxx@xxx.xxx

COMMENTS

author: Myah Faulkner
date: 2015-07-16 13:38:37.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-07-16 13:38:43.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6036/

-------------------------------------
author: Brenden Conley
date: 2015-07-16 14:02:10.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6036/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-07-16 14:43:48.000000000

Patch Set 3:

(2 comments)

Line:106, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DirectContributionItem.java -> I dislike dead code. Why is this here?

Line:124, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DirectContributionItem.java -> Default false (see above), this will lead to logging. I would log it dynamically, if the -debug flag is set.

-------------------------------------
author: Myah Faulkner
date: 2015-07-16 14:53:55.000000000

Patch Set 3:

(2 comments)

Line:106, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DirectContributionItem.java -> Why is it dead code?

Explanation below.

Line:124, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DirectContributionItem.java -> this code is copied from HandledContributionItem, so the behavior is the same for both. I guessed that the one who implemented it had a reason I didn't wanted to ask for in this contribution.

We can think of a general overhauling here in another ticket IMHO. E.g. some sort of parent class to abstract out the similarities

-------------------------------------
author: Zaid Mosley
date: 2015-07-16 14:55:39.000000000

Patch Set 3: Code-Review+1 Verified+1

(1 comment)

Line:124, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/DirectContributionItem.java -> +1 please open a ticket for this rework. Otherwise all looks good, please feel free to submit.

-------------------------------------
author: Myah Faulkner
date: 2015-07-16 19:58:46.000000000

Patch Set 4: Patch Set 3 was rebased

-------------------------------------
