DESCRIPTION

Bug 472761 - No toolbar drag and drop with "-cssTheme none"

Change-Id: I8452f52f1bc408f742639faf94cd67cef9a8218c
Signed-off-by: Chase Horton xxx@xxx.xxx

COMMENTS

author: Chase Horton
date: 2015-07-16 10:41:21.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-07-16 10:41:27.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6032/

-------------------------------------
author: Chase Horton
date: 2015-07-16 10:44:49.000000000

Patch Set 1:

Since the cssEngine is null I had to use the JFace facilities to manage the icon's lifecycle. First tries to get it from CSS - if not available then get the default one (which I packaged in the o.e.e4.ui.workLeon Ochoach.swt bundle).

-------------------------------------
author: Brenden Conley
date: 2015-07-16 11:05:17.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6032/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-07-16 15:28:13.000000000

Patch Set 1:

(1 comment)

Line:53, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/CSSRenderingUtils.java -> Why $nl$?  Why not $ws$?

-------------------------------------
author: Jayvion Booth
date: 2015-07-16 18:00:21.000000000

Patch Set 1: Code-Review+1

Tried with both GTK2/GTK3, looks good. Code is OK for me too.

-------------------------------------
author: Teagan Marsh
date: 2015-07-16 18:23:45.000000000

Patch Set 1:

Just to explain my $ws$ remark, I think it's far more likely that an RCP app developer will want to create custom drag-handle images on a per-platform basis than per-language basis.

I'm unsure how a french drag-handle might differ from an english drag handle :-)

-------------------------------------
author: Jayvion Booth
date: 2015-07-16 18:25:16.000000000

Patch Set 1:

yes, $ws$ makes sense.

-------------------------------------
author: Chase Horton
date: 2015-07-17 08:51:28.000000000

Patch Set 1:

> Just to explain my $ws$ remark, I think it's far more likely that
 > an RCP app developer will want to create custom drag-handle images
 > on a per-platform basis than per-language basis.
 > 
 > I'm unsure how a french drag-handle might differ from an english
 > drag handle :-)

It would be a romantic handél? :)

Thanks for spotting. I'll change it to ws. Copy paste miss.

-------------------------------------
