DESCRIPTION

Bug 472690 - Allow construction of MessageDialog with varargs

Change-Id: If08f83cd9fa59fcf4aa96d3129eb6ca7f90968d2
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2015-07-17 03:50:55.000000000

Patch Set 4:

Dirk, can you give your feedback?

-------------------------------------
author: Brenden Conley
date: 2015-07-17 05:34:16.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6043/

-------------------------------------
author: Brenden Conley
date: 2015-07-17 06:16:14.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6043/ : SUCCESS

-------------------------------------
author: Myah Faulkner
date: 2015-07-17 06:24:48.000000000

Patch Set 4:

(2 comments)

Line:143, bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialog.java -> which

Line:236, bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialog.java -> I think there is something wrong with your formatting rules. This class has mixed tabs/spaces for indentation. This leads to a strange looking formatting in Gerrit.

-------------------------------------
author: Zaid Mosley
date: 2015-07-23 15:04:42.000000000

Patch Set 4:

(1 comment)

Line:236, bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialog.java -> True, the old code is incorrectly formatted hence it looks weird in Gerrit but we do not reformat untouched lines. Legacy we have to live with...

-------------------------------------
author: Gerrit Code Review
date: 2015-07-24 08:15:26.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
