DESCRIPTION

Bug 472673, 335792 - Add generics to the databinding.property plugin

Change-Id: I88f7544029fab09515c48c94cb333a094089d9a0
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2015-07-17 23:08:03.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6066/

-------------------------------------
author: Brenden Conley
date: 2015-07-17 23:31:19.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6066/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2015-07-20 05:37:00.000000000

Patch Set 6:

(10 comments)

Line:97, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/list/SimplePropertyObservableList.java -> Would <> work?

Line:290, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/set/SimplePropertyObservableSet.java -> Fits into previous line.

Line:74, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SetSimpleValueObservableMap.java -> Fits into previous line.

Line:74, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SetSimpleValueObservableMap.java -> Unclear comment.

Line:128, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SetSimpleValueObservableMap.java -> What does "later code" mean?

Line:156, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/DelegatingCache.java -> The comment seems to be invalid.

Line:42, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/Properties.java -> Unnecessary blank line unrelated to the rest of the change.

Line:101, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/Properties.java -> Are these new methods really needed?

Line:314, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/ListSimpleValueObservableList.java -> What does "Us" stand for?

Line:150, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/MapSimpleValueObservableMap.java -> Unclear comment.

-------------------------------------
author: Kelly Potter
date: 2015-08-01 00:28:54.000000000

Patch Set 6:

(9 comments)

Line:97, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/list/SimplePropertyObservableList.java -> Done

Line:290, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/set/SimplePropertyObservableSet.java -> Done

Line:74, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SetSimpleValueObservableMap.java -> Delorted.

Line:128, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SetSimpleValueObservableMap.java -> Reworded comment. It is describing a legitimate design flaw in this class, so I kept the comment.

Line:156, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/DelegatingCache.java -> The comment looks valid to me. Actually, more than that -- it looks like a design flaw. It seems quite possible for this method to be invoked with something other than an element of type S, which will cause that CCE. I've reworded the comment to make this a little more clear.

Line:42, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/Properties.java -> Done

Line:101, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/Properties.java -> They don't seem to be. Removed.

Line:314, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/ListSimpleValueObservableList.java -> Done

Line:150, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/MapSimpleValueObservableMap.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2015-08-03 01:52:23.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
