DESCRIPTION

Bug 468773 - Perspective should be a HandlerContainer

https://bugs.eclipse.org/bugs/show_bug.cgi?id=468773

Change-Id: I5e232916655cb2be7896c3fd578009f255f7c65a
Signed-off-by: Emma Robertson xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2015-08-11 10:09:32.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6306/

-------------------------------------
author: Brenden Conley
date: 2015-08-11 10:59:11.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/6306/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-08-11 14:41:27.000000000

Patch Set 6:

(2 comments)

I'll retract my suggestion.

I found two other things when I took a second look.

Line:116, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workLeon Ochoach/HandlerActivationTest.java -> Should this be stackB?

Line:140, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workLeon Ochoach/HandlerActivationTest.java -> This comment doesn't seem to be true?

-------------------------------------
author: Emma Robertson
date: 2015-08-11 14:58:30.000000000

Patch Set 6:

> (2 comments)
 > 
 > I'll retract my suggestion.
 > 
 > I found two other things when I took a second look.

Good catch! I will look into that...

-------------------------------------
author: Gerrit Code Review
date: 2015-08-13 13:52:21.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2015-08-13 13:52:36.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
