DESCRIPTION

Bug 335792 - databinding plugin - The generics type parameters need
             to be specified in data binding classes

Change-Id: I6ea2644d0a2395a16a29d554587d8ccd9de3b9a9
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Kelly Potter
date: 2015-06-19 01:14:34.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2015-06-19 01:23:17.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5895/

-------------------------------------
author: Brenden Conley
date: 2015-06-19 01:29:23.000000000

Patch Set 8: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5895/ : FAILURE

-------------------------------------
author: Brock Pruitt
date: 2015-06-20 01:53:29.000000000

Patch Set 8:

(141 comments)

Line:135, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableMap.java -> Fits into previous line.

Line:138, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableMap.java -> Fits into previous line.

Line:143, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableMap.java -> Fits into previous line.

Line:182, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableMap.java -> Remove the space after <K, V>

Line:182, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableMap.java -> Fits into previous line.

Line:101, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DataBindingContext.java -> Better to break after =

Line:105, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DataBindingContext.java -> Better to break after =

Line:109, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DataBindingContext.java -> Fits into previous line.

Line:132, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DataBindingContext.java -> Fits into previous line.

Line:378, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DataBindingContext.java -> Fits into previous line.

Line:384, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DataBindingContext.java -> Fits into previous line.

Line:27, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToBooleanPrimitiveConverter.java -> Fits into previous line.

Line:27, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToBooleanPrimitiveConverter.java -> Why not <String, Boolean>?

Line:34, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToBooleanPrimitiveConverter.java -> Fits into previous line.

Line:36, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToBooleanPrimitiveConverter.java -> Fits into previous line.

Line:51, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToBooleanPrimitiveConverter.java -> <> would do.

Line:134, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateStrategy.java -> Better to break after =

Line:152, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateStrategy.java -> Better to break after =

Line:185, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateStrategy.java -> <> would do

Line:20, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToCharacterConverter.java -> Why not <String, Character>?

Line:77, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ObjectToPrimitiveValidator.java -> Fits into previous line.

Line:85, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ObjectToPrimitiveValidator.java -> Line break after ( is preferable to line break before dot.

Line:95, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/Activator.java -> Better to break after :

Line:28, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java -> Fits into previous line.

Line:36, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java -> Fits into previous line.

Line:42, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java -> Fits into previous line.

Line:139, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java -> Better: ValidationStatusProvider validationStatusProvider : validationStatusProviders

Line:143, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java -> Fits into previous line.

Line:154, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java -> Fits into previous line.

Line:178, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java -> Better: ValidationStatusProvider validationStatusProvider : validationStatusProviders

Line:182, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/AggregateValidationStatus.java -> Fits into previous line.

Line:42, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderModelsProperty.java -> Fits into previous line.

Line:48, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderModelsProperty.java -> Fits into previous line.

Line:19, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/CharacterToStringConverter.java -> Should it be <Character, String>?

Line:28, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/IntegerToStringConverter.java -> Should it be <Integer, String>?

Line:42, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderTargetsProperty.java -> Fits into previous line.

Line:48, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderTargetsProperty.java -> Fits into previous line.

Line:84, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/IdentityConverter.java -> Fits into previous line.

Line:230, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateValueStrategy.java -> T -> D

Line:276, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateValueStrategy.java -> Better to break after =

Line:507, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateValueStrategy.java -> Line break after ( is preferable to line break before dot.

Line:568, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateValueStrategy.java -> Fits into previous line.

Line:26, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/BindingTargetProperty.java -> Fits into previous line.

Line:163, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateSetStrategy.java -> Fits into previous line.

Line:169, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateSetStrategy.java -> Fits into previous line.

Line:215, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateSetStrategy.java -> Line break after ( is preferable to line break before dot.

Line:231, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateSetStrategy.java -> Fits into previous line.

Line:235, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateSetStrategy.java -> Line break after ( is preferable to line break before dot.

Line:67, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/IdentitySet.java -> Remove the space after <E>

Line:78, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/IdentitySet.java -> Remove the space after <Object>

Line:97, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/IdentitySet.java -> Fits into previous line.

Line:168, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/IdentitySet.java -> Fits into previous line.

Line:135, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusMap.java -> Fits into previous line.

Line:155, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusMap.java -> Fits into previous line.

Line:66, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> <> would do.

Line:118, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> Fits into previous line.

Line:203, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> Fits into previous line.

Line:222, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> Remove the space after <E>

Line:222, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> Fits into previous line.

Line:249, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> Line break after ( is preferable to line break before dot.

Line:274, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> Line break after ( is preferable to line break before dot.

Line:317, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> Line break after ( is preferable to line break before dot.

Line:383, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> <> would do.

Line:397, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableList.java -> <> would do.

Line:31, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/NumberToByteConverter.java -> Fits into previous line.

Line:30, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/NumberToNumberValidator.java -> Why not <Number>?

Line:81, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/NumberToNumberValidator.java -> Line break after ( is preferable to line break before dot.

Line:69, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ClassLookupSupport.java -> Fits into previous line.

Line:26, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/NumberToNumberConverter.java -> Why not <Number, Number>?

Even better yet it would be declare NumberToNumberConverter<S extends Number, T extends Number>

Line:23, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToDateConverter.java -> Better to break before 'implements'

Line:193, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java -> Fits into previous line.

Line:276, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java -> Fits into previous line.

Line:295, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java -> Fits into previous line.

Line:359, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java -> Fits into previous line.

Line:441, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java -> Fits into previous line.

Line:493, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java -> Fits into previous line.

Line:515, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/validation/MultiValidator.java -> Fits into previous line.

Line:53, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Fits into previous line.

Line:63, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Fits into previous line.

Line:126, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Remove the space after <M>

Line:128, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Fits into previous line.

Line:140, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Remove the space after <T>

Line:142, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Fits into previous line.

Line:230, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Fits into previous line.

Line:235, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ListBinding.java -> Fits into previous line.

Line:163, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Fits into previous line.

Line:169, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Fits into previous line.

Line:213, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Fits into previous line.

Line:218, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Line break after ( is preferable to line break before dot.

Line:238, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Line break after ( is preferable to line break before dot.

Line:286, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Fits into previous line.

Line:291, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Line break after ( is preferable to line break before dot.

Line:309, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Fits into previous line.

Line:314, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateListStrategy.java -> Line break after ( is preferable to line break before dot.

Line:102, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/BindingProperties.java -> Remove the space after <IStatus>

Line:44, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ValueBinding.java -> Util -> Objects

Line:45, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ValueBinding.java -> Fits into previous line.

Line:56, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ValueBinding.java -> Fits into previous line.

Line:40, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToShortConverter.java -> Fits into previous line.

Line:62, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToShortConverter.java -> Line break after ( is preferable to line break before dot.

Line:26, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/BindingModelProperty.java -> Fits into previous line.

Line:44, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/NumberToStringConverter.java -> Fits into previous line.

Line:57, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/NumberToStringConverter.java -> Better: ClassNotFoundException | NoSuchMethodException e

Line:135, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/NumberToStringConverter.java -> Better: InstantiationException | InvocationTargetException | IllegalAccessException e

Line:282, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/NumberToStringConverter.java -> Fits into previous line.

Line:304, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/NumberToStringConverter.java -> Fits into previous line.

Line:27, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/DataBindingContextBindingsProperty.java -> Better to break before 'extends'

Line:45, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToByteConverter.java -> Fits into previous line.

Line:81, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/StringToByteConverter.java -> Line break after ( is preferable to line break before dot.

Line:179, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java -> Remove the space after <IObservable>

Line:194, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/Binding.java -> Remove the space after <IObservable>

Line:26, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/NumberToIntegerConverter.java -> Better to break before 'implements'

Line:27, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/NumberToIntegerConverter.java -> Why not <Number, Integer>?

Line:37, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/NumberToIntegerConverter.java -> Fits into previous line.

Line:115, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ObservablesManager.java -> Fits into previous line.

Line:119, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ObservablesManager.java -> Fits into previous line.

Line:121, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ObservablesManager.java -> Fits into previous line.

Line:123, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ObservablesManager.java -> Fits into previous line.

Line:33, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/NumberToBigIntegerConverter.java -> Fits into previous line.

Line:109, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/StringToNumberConverter.java -> Combine exception clauses.

Line:217, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/StringToNumberConverter.java -> Combine exception clauses.

Line:247, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/StringToNumberConverter.java -> Fits into previous line.

Line:396, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/StringToNumberConverter.java -> Fits into previous line.

Line:419, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/conversion/StringToNumberConverter.java -> Fits into previous line.

Line:54, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java -> Fits into previous line.

Line:64, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java -> Fits into previous line.

Line:127, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java -> Remove the space after <M>

Line:127, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java -> Fits into previous line.

Line:140, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java -> Remove the space after <T>

Line:184, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java -> Better: S element : diff.getRemovals()

Line:196, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/SetBinding.java -> Better: S element : diff.getAdditions()

Line:110, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableSet.java -> Fits into previous line.

Line:135, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableSet.java -> Fits into previous line.

Line:139, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableSet.java -> Fits into previous line.

Line:204, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableSet.java -> Fits into previous line.

Line:231, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ValidatedObservableSet.java -> Line break after ( is preferable to line break before dot.

Line:27, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/DataBindingContextValidationStatusProvidersProperty.java -> Better to break before 'extends'

Line:24, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/DateToStringConverter.java -> Better to break before 'implements'

Line:28, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/IdentityWrapper.java -> Better: IdentityWrapper<?> NULL_WRAPPER = new IdentityWrapper<>(null)

Line:87, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/AbstractStringToNumberValidator.java -> Line break after ( is preferable to line break before dot.

Line:25, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/StringToCharacterValidator.java -> Why not <String>?

-------------------------------------
author: Brock Pruitt
date: 2015-06-20 02:55:19.000000000

Patch Set 8:

To fix the build you need to update the plugin version in pom.xml file.

-------------------------------------
author: Zaid Mosley
date: 2015-08-14 14:24:42.000000000

Patch Set 9: Patch Set 8 was rebased

-------------------------------------
