DESCRIPTION

Bug 335792 - The generics type parameters need to be specified in data binding classes

Change-Id: I0789ca45da254f67b9644d5b88d6438242d66e3c
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Kelly Potter
date: 2015-06-17 02:46:26.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-06-17 02:46:32.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5868/

-------------------------------------
author: Brenden Conley
date: 2015-06-17 02:51:22.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5868/ : FAILURE

-------------------------------------
author: Brock Pruitt
date: 2015-06-17 03:24:11.000000000

Patch Set 3:

(10 comments)

Here are comments for the first 15 files.

Line:68, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableTracker.java -> Diamond operator <> would suffice.

Same below.

Line:119, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeManager.java -> xxx@xxx.xxx

Line:52, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Diffs.java -> new ArrayList<>() would be sufficient.

Line:87, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java -> Describe.

Same below.

Line:257, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java -> This method should be parameterized similar to Collections.emptyList()

Same for other emptyObservable* methods.

Line:45, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListDiff.java -> Why not ListDiffEntry<E>?

Line:69, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ListDiff.java -> Diamond operator <> is sufficient.

Line:82, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Realm.java -> <> would do.

Line:262, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ComputedList.java -> Fits into previous line?

Line:264, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ComputedList.java -> Ditto.

-------------------------------------
author: Kelly Potter
date: 2015-06-18 03:12:47.000000000

Patch Set 3:

(5 comments)

Line:68, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableTracker.java -> Done

Line:119, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ChangeManager.java -> Actually, the comment was bogus. There was no such warning so I deleted the comment.

Line:52, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Diffs.java -> Done

Line:87, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java -> Done

Line:82, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Realm.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2015-07-17 23:05:57.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
