DESCRIPTION

Bug 413952 - Updating workLeon Ochoach context by WorkbenchConfigurer added

Change-Id: I2fab9f65292608ba6384156b855bd18f1f9834f0
Signed-off-by: Brennen Robles xxx@xxx.xxx


COMMENTS

author: Brennen Robles
date: 2015-06-09 22:33:37.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-06-09 22:33:43.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5854/

-------------------------------------
author: Brenden Conley
date: 2015-06-09 22:46:38.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5854/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-08-15 02:30:36.000000000

Patch Set 1:

(3 comments)

Nice work, Bartosz.  Just one real issue: WorkLeon OchoachConfigurer should retrieve the value from the e4Context.  And why don't we use DI to create the WorkbenchConfigurer rather than pass in the context?

Line:125, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchConfigurer.java -> This should retrieve the value from the e4Context, and we should get rid of this shadow saveAndRestore value

Line:72, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchConfigurer.java -> If we create the configurer using DI, this should xxx@xxx.xxx

Line:3225, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> I'm thinking we should just create the object using DI:

	workLeon OchoachConfigurer = ContextInjectionFactory.make(WorkbenchConfigurer.class, e4Context);

-------------------------------------
author: Gerrit Code Review
date: 2015-10-27 11:19:46.000000000

Change has been successfully merged into the git repository by Teagan Marsh

-------------------------------------
