DESCRIPTION

Bug 466233 - Toolbar items are wrongly rendered into a "drop-down"

Change-Id: I1688e0cbe9abb600079c40d0645e291438eb6f3f
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Jayvion Booth
date: 2015-05-10 21:23:03.000000000

Patch Set 2: Code-Review+1

-------------------------------------
author: Brenden Conley
date: 2015-05-10 21:46:48.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5771/

-------------------------------------
author: Brenden Conley
date: 2015-05-10 21:58:47.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5771/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-05-11 07:18:49.000000000

Patch Set 2:

(1 comment)

Looks good but I would not introduce a new method for the lines.clear() statement

Line:154, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/TrimBarLayout.java -> I don't see the advantages of having this single statement method. I suggest to inline that again.

-------------------------------------
author: Kaeden Tapia
date: 2015-05-11 15:04:28.000000000

Patch Set 2:

(1 comment)

Line:154, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/TrimBarLayout.java -> Done

-------------------------------------
