DESCRIPTION

Bug 465711 - Rendering of tabs when hovering using a dark theme makes
tab unreadable (CTabRendering)

Change-Id: I763285dd36f639ca2331ce9e0d41b146387dc0ba
Signed-off-by: Sienna Tate xxx@xxx.xxx

COMMENTS

author: Sienna Tate
date: 2015-04-28 17:26:27.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-04-28 17:26:33.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5552/

-------------------------------------
author: Brenden Conley
date: 2015-04-28 18:09:50.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5552/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-04-28 18:21:30.000000000

Patch Set 1:

(4 comments)

Looks good except a few minor things. AFAIK I can see no API is added so if you fix that it can go into M7.

Line:97, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java -> Not the greatest name ever but I cannot think about a better one myself

Line:107, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java -> We do not add non-Javadoc

Line:113, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java -> Typo Colo

Line:25, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/internal/css/swt/ICTabRendering.java -> Typo "Colo"

-------------------------------------
