DESCRIPTION

Bug 465445 - Removed compiler warnings. 

Change-Id: Icd756fc90a892ecb89d3f217dceda5dc2dd3180f
Signed-off-by: Luciano Vang xxx@xxx.xxx

COMMENTS

author: Brock Pruitt
date: 2015-04-25 22:31:21.000000000

Patch Set 2: Commit message was updated

-------------------------------------
author: Brenden Conley
date: 2015-04-25 22:31:27.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5531/

-------------------------------------
author: Brock Pruitt
date: 2015-04-25 22:57:37.000000000

Patch Set 2:

(12 comments)

What is the relationship between this change and bug 465445?

Please restrict the change to removal of compiler warnings.

Line:70, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/JobsView.java -> Unnecessary blank line.

Line:313, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/JobsView.java -> Why not just replace Platform with Job?

Same below.

Line:512, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/JobsView.java -> Why changed?

Line:617, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/JobsView.java -> Why changed?

Line:29, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/actions/DebugJobManagerAction.java -> Trivial comment.

Line:45, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/actions/DebugJobManagerAction.java -> Why not simply replace Platform with Job?

Line:60, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/SlowElementAdapter.java -> Remove the comment.

Line:40, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/ProgressExamplesPlugin.java -> The plugin runtime object and bundle are two different things.

Line:24, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/TestJobRule.java -> Trivial comment.

Line:26, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/TestJobRule.java -> Description is missing.

Line:53, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/TestJobRule.java -> Description with a negative value.

Line:27, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/views/DeferredContentProvider.java -> What is this change for?

-------------------------------------
author: Brenden Conley
date: 2015-04-25 23:14:29.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5531/ : SUCCESS

-------------------------------------
author: King Boyle
date: 2015-04-28 10:36:10.000000000

Patch Set 2:

Dear Sergey, I see you have a clear understanding how to document code. Do I understand the review points correct, that adding comments isn't expected  even if the style checker marks the lines ? I ask this because I had my first Hackathon and I want to learn the Eclipse development process.

-------------------------------------
author: Zaid Mosley
date: 2015-04-28 10:45:45.000000000

Patch Set 2:

(1 comment)

Hi Luciano Vang, reviews tend to be short, as committers do not have a lot of time. Here are a few clarifications to Sergeys comments

Unnecessary blank line -> should be removed
Trivial comment -> should be removed
Why changed? -> Change should be removed or you explain why this change is necessary
Remove the comment. -> Remove the comment

Line:24, examples/org.eclipse.ui.examples.job/src/org/eclipse/ui/examples/jobs/TestJobRule.java -> This comment can be removed

-------------------------------------
author: Gerrit Code Review
date: 2015-09-22 16:52:33.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2015-09-22 19:28:31.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2016-08-17 11:17:56.000000000

Change cannot be merged due to unsatisfiable dependencies.

The following dependency errors were found:

* Depends on patch set 1 of I58c552ea, however the current patch set is 2.

Please rebase the change and upload a replacement commit.

-------------------------------------
author: Gerrit Code Review
date: 2016-08-17 11:18:30.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
