DESCRIPTION

Bug 465292 - EModelService.move methods have no type parameter
https://bugs.eclipse.org/bugs/show_bug.cgi?id=465292

Change-Id: I1255fba5846a51bd2dea3cdc2ab663c48dc8f05b
Signed-off-by: jonas xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2015-04-24 09:05:42.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5518/

-------------------------------------
author: Brenden Conley
date: 2015-04-24 09:48:11.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5518/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-04-24 18:20:43.000000000

Patch Set 4:

> Thanks for the comment Brian. MElementContainer<? super T> would work as well. However, in this use case I cannot think of any example, where it actually makes any difference, can you? If you prefer I can adapt, but IMHO it makes no difference here.

It makes no difference here but it goes against best practice (viz Bloch's Effective Java) and may bite us (or somebody else) later.  Take a look at Collections.fill(List<? super T>,T) and java.util.Collections.addAll(List<? super T>,T…).

I expect that we'll want a move(MElementContainer<? super T> container, Collection<? extends T> children) variants at some point too.

-------------------------------------
author: Gerrit Code Review
date: 2015-07-28 13:42:28.000000000

Change has been successfully merged into the git repository by Teagan Marsh

-------------------------------------
