DESCRIPTION

[Win32] Dark theme: tree must respect the foreground color for items
arrows

Change-Id: I338516b98b2a78b6ab70c03c291a590498e2b49d
Signed-off-by: Gianni Hancock xxx@xxx.xxx

COMMENTS

author: Sienna Tate
date: 2015-04-02 17:55:48.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-04-02 18:03:20.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5265/

-------------------------------------
author: Teagan Marsh
date: 2015-04-02 18:20:03.000000000

Patch Set 1:

(4 comments)

Thanks Fabio, this is a great start.

I think that it would be a bit more general if the property took a colour as an argument (see CSSPropertyShadowColorHandler for an example).

The arrow size needs work; we can't just hard code some pixel numbers.

Line:49, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/custom/CSSPropertyTreeArrowsSWTHandler.java -> It would probably be better if the property specified the arrow colour

Line:58, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/custom/CSSPropertyTreeArrowsSWTHandler.java -> Do these hard-coded values work for different font sizes?

Line:481, bundles/org.eclipse.e4.ui.css.swt/plugin.xml -> Should define a TreeElement, just like CompositeElement.

Line:19, bundles/org.eclipse.ui.themes/css/e4-dark_win.css -> I think it'd be better to support a colour here…

-------------------------------------
author: Brenden Conley
date: 2015-04-02 18:24:46.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5265/ : SUCCESS

-------------------------------------
author: Sienna Tate
date: 2015-04-02 18:46:56.000000000

Patch Set 1:

(3 comments)

> (4 comments)
 > 
 > Thanks Fabio, this is a great start.
 > 
 > I think that it would be a bit more general if the property took a
 > colour as an argument (see CSSPropertyShadowColorHandler for an
 > example).
 > 
 > The arrow size needs work; we can't just hard code some pixel
 > numbers.

 > (4 comments)
 > 
 > Thanks Fabio, this is a great start.
 > 
 > I think that it would be a bit more general if the property took a
 > colour as an argument (see CSSPropertyShadowColorHandler for an
 > example).
 > 
 > The arrow size needs work; we can't just hard code some pixel
 > numbers.

Line:49, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/custom/CSSPropertyTreeArrowsSWTHandler.java -> The only issue is that I'd have to create a new PaintListener for each tree -- or add the color to the tree data (setData/getData).

If that's the case, I'm more inclined to create a constant at CSSPropertyTreeArrowsSWTHandler regarding the color ("org.eclipse.e4.ui.css.swt.tree_item_foreground_color") and then do a getData() at the painter as that'd be more memory efficient than creating a new painter for each tree with the color.

Line:58, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/custom/CSSPropertyTreeArrowsSWTHandler.java -> They should (the arrow size is not dependent on the size of the font as far as I know).

Also, these values are being used in LiClipse: http://www.liclipse.com/ for quite a while already and no one complained so far :)

Line:481, bundles/org.eclipse.e4.ui.css.swt/plugin.xml -> Ok, will do.

-------------------------------------
author: Sienna Tate
date: 2015-04-02 19:50:32.000000000

Abandoned

Ended up rebasing outside and ended with a new review (which should address the current issues) https://git.eclipse.org/r/#/c/45175/

-------------------------------------
