DESCRIPTION

Bug 463245 - Debug toolbar items not visible until restart with CDT

Change-Id: Iedd0c3d092f64993e6413dde15bc601e26b6aa4a
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2015-03-27 20:53:04.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-03-27 20:56:12.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5208/

-------------------------------------
author: Myah Faulkner
date: 2015-03-27 21:11:01.000000000

Patch Set 1:

(1 comment)

Line:215, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> isn't it sufficient to perform that check on line 217?

This is what I have added for the other bugfix. With your check even no layout() is called in such a case.

-------------------------------------
author: Brenden Conley
date: 2015-03-27 21:19:09.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5208/ : SUCCESS

-------------------------------------
author: Kaeden Tapia
date: 2015-03-27 21:29:34.000000000

Patch Set 1:

(1 comment)

Line:215, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> yes it works it I do the check on line 217. Right, it's on the shell that layout is called. Should Line 216 also be inside the null check since it also calls pack?

-------------------------------------
author: Myah Faulkner
date: 2015-03-27 21:40:10.000000000

Patch Set 1:

(1 comment)

Line:215, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> It wasn't necessary before, so I would only add the check on line 217 to avoid any regressions

-------------------------------------
author: Kaeden Tapia
date: 2015-03-27 21:45:02.000000000

Patch Set 1:

(1 comment)

Line:215, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Done

-------------------------------------
