DESCRIPTION

Bug 442285 - Update EventBroker usage in StackRenderer

Change-Id: I879ee574e77ce7e2372b7848458b012e04f75d73
Signed-off-by: Averie Phelps xxx@xxx.xxx


COMMENTS

author: Zaid Mosley
date: 2015-04-24 02:04:08.000000000

Patch Set 5: Code-Review+1 Verified+1

Brian, looks good to me. Any further comments from your side?

-------------------------------------
author: Teagan Marsh
date: 2015-04-24 02:47:45.000000000

Patch Set 5:

(9 comments)

There are TODO comments have been discarded.  That's fine if you've verified that they aren't applicable, but otherwise we're losing information that may be valuable.

I think the method names need to be improved; I'm not suggesting that the original variable names were great, but we want to improve readability of the code.  

It would also be easier to review if the new methods were carved out in-place rather than creating methods elsewhere in the file.  Since you're not actually changing the code in the event handlers, the changeset will show up purely as indentation changes.

Line:355, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Could you move this comment up too?

Line:408, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Move this comment too

Line:323, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> handleTabActivation?

Line:370, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> handleTitleChange

Line:413, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> handleDirtyFlagChange

Line:460, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> handleViewMenuVisibilityChange

Line:466, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> handleMenuToBeRenderedChange

Line:475, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> No blank line

Line:476, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> This isn't a particularly useful name: updatePotentialViewMenu?

-------------------------------------
author: Brenden Conley
date: 2015-04-24 03:45:55.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5513/

-------------------------------------
author: Brenden Conley
date: 2015-04-24 04:10:02.000000000

Patch Set 5: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5513/ : FAILURE

-------------------------------------
