DESCRIPTION

Bug 442285 - Update EventBroker usage in StackRenderer

Change-Id: I879ee574e77ce7e2372b7848458b012e04f75d73
Signed-off-by: Averie Phelps xxx@xxx.xxx


COMMENTS

author: Averie Phelps
date: 2015-03-16 20:07:30.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2015-03-16 20:07:36.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5058/

-------------------------------------
author: Brenden Conley
date: 2015-03-16 20:47:22.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5058/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-03-24 20:58:38.000000000

Patch Set 2: Code-Review-1

(3 comments)

A few tweaks

Line:194, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Please keep the comments

Line:206, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Please keep the comments

Line:552, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Can't we change tabStatehandler to two methods that simply delegate to a common method?

-------------------------------------
author: Zaid Mosley
date: 2015-04-07 11:36:38.000000000

Patch Set 2:

Thibault, any update?

-------------------------------------
author: Averie Phelps
date: 2015-04-07 11:43:37.000000000

Patch Set 2:

@Lars: Sure will update it within the next few days

-------------------------------------
