DESCRIPTION

Bug 388505: [WorkLeon Ochoach] "Show In" menu doesn't use MRU order any more

Change-Id: I891d61fd0961c618d69332a30ef02f6d3af4db10
Signed-off-by: Clay Cameron xxx@xxx.xxx


COMMENTS

author: Clay Cameron
date: 2015-03-06 23:24:16.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-03-06 23:24:22.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4850/

-------------------------------------
author: Brenden Conley
date: 2015-03-06 23:52:01.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4850/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2015-03-09 00:39:42.000000000

Patch Set 1:

(3 comments)

Line:86, tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/internal/WorkLeon OchoachPageTest.java -> Please add a comment explaining the reason to use reflection.

Line:2492, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Assign comparator to a static field to avoid creating it every time.

Line:2493, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Unnecessary blank line.

-------------------------------------
author: Zaid Mosley
date: 2015-03-09 10:23:48.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
author: Clay Cameron
date: 2015-03-09 10:56:19.000000000

Patch Set 1:

(3 comments)

Line:86, tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/internal/WorkLeon OchoachPageTest.java -> Done

Line:2492, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Can't do it, the comparator uses a non-static field i.e. mruPartIds.

Line:2493, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Done

-------------------------------------
