DESCRIPTION

Bug 234331 - [Viewers] IStructuredSelection should be Iterable

This patch generifies IStructuredSelection without introducing
dependency on Iterable that requires
https://bugs.eclipse.org/bugs/show_bug.cgi?id=441168 to be resolved
first.

Change-Id: Ifc100379efe3bd4d75a38092639c0437103953ab
Signed-off-by: Brock Pruitt xxx@xxx.xxx


COMMENTS

author: Brock Pruitt
date: 2015-02-26 06:43:23.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2015-02-26 06:46:18.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4726/

-------------------------------------
author: Brenden Conley
date: 2015-02-26 07:09:42.000000000

Patch Set 5: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4726/ : UNSTABLE

-------------------------------------
author: Zaid Mosley
date: 2015-02-26 07:13:38.000000000

Patch Set 5:

We have done a lot of work for the gentrification of JFace already (currently at GitHub) repo and I plan to work on this early Eclipse Mars+1 so that dependent projects can fix their warnings. For Mars I suggest to leave JFace without genetics.

-------------------------------------
author: Dashawn Dalton
date: 2015-02-26 10:51:38.000000000

Patch Set 5: Code-Review-2

(1 comment)

Line:182, bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/StructuredSelection.java -> We won't do that, since it's totally unsafe. Clients can't know for sure what type of elements the selection contains, so they have to be prepared to handle all Objects.

-------------------------------------
author: Brock Pruitt
date: 2015-02-26 15:06:33.000000000

Abandoned

Abandoning for now.

-------------------------------------
