DESCRIPTION

Bug 458832 - [WorkLeon Ochoach] Replace deprecated Preference access in
IDEWorkspacePreferencePage 

Change-Id: Iac492ec0430b5f6b18fe945e33db60b0d2aaa945
Signed-off-by: Jayden Ramos xxx@xxx.xxx

COMMENTS

author: Jayden Ramos
date: 2015-02-24 21:47:11.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-02-24 21:47:18.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4709/

-------------------------------------
author: Brenden Conley
date: 2015-02-24 22:08:25.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4709/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-02-26 19:49:16.000000000

Patch Set 3: Code-Review-1

(1 comment)

See my question

Line:474, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java -> Why DefaultScope here and ConfigurationScope in line 561?

-------------------------------------
author: Jayden Ramos
date: 2015-02-26 23:09:31.000000000

Patch Set 3:

(1 comment)

Line:474, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java -> This one performs the default, so I choose the DefaultScope.
The other will be perform by pressing the ok button so I choose the Configuration Scope. This is not the default in my opinion.(My answer coming so late, because I overlooked the reply button...)

-------------------------------------
author: Zaid Mosley
date: 2015-04-17 14:09:18.000000000

Patch Set 3: -Code-Review

Nevaeh Wu, can you review this one?

-------------------------------------
author: Krista Shepherd
date: 2015-04-20 17:37:34.000000000

Patch Set 3:

(1 comment)

Please use the InstanceScope instead of the ConfigurationScope. See inline comment.

Line:561, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java -> I checked, which preferncestore is used here with the preference spy and figured out the InstanceScope should be used here.

-------------------------------------
