DESCRIPTION

Bug 334391 - [Contributions] java.lang.IllegalArgumentException in
CustomizePerspectiveDialog

NameAndDescriptionToolTip should not call setText() on Label if the text
is null, and CPD should use getText() from Toolitem's if they have
getToolTipText() == null.

Change-Id: Id8883d367ef143c6c6b70656e527ca9a1f318fc7
Signed-off-by: Jayvion Booth xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2015-02-15 16:02:09.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4545/

-------------------------------------
author: Brenden Conley
date: 2015-02-15 16:17:57.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4545/ : SUCCESS

-------------------------------------
author: Sebastian Porter
date: 2015-02-19 13:14:13.000000000

Patch Set 3:

Are there steps that allow to reproduce the problem and verify the fix?

-------------------------------------
author: Jayvion Booth
date: 2015-02-19 13:20:32.000000000

Patch Set 3:

Bug 334391 comment 2 gives an idea how this can happen - there must be an ActionContributionItem with null tooltip.

Scenarios to reproduce:
a)
1)Add item with icon
2)Set mode to "FORCE_TEXT"
3)Empty tooltip, or tooltip==label

open Window->Customize Perspective.. and then hover mouse under above action item.

b) Just add item without icon and without mode "FORCE_TEXT", but with tooltip==label

open Window->Customize Perspective.. and then hover mouse under above action item.

The problem described in comment 1 is still there.

-------------------------------------
author: Gerrit Code Review
date: 2015-03-24 18:13:04.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
