DESCRIPTION

Bug 459285 - CCE in MinMaxAddon when trying to remove a perspective from
a non MTrimmedWindow

Change-Id: Ifce0b0a79a2e4e4f49e57dcfcf031bc0f25a4099
Signed-off-by: Myah Faulkner xxx@xxx.xxx

COMMENTS

author: Myah Faulkner
date: 2015-02-13 12:17:58.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2015-02-13 14:33:06.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4531/

-------------------------------------
author: Brenden Conley
date: 2015-02-13 15:00:08.000000000

Patch Set 6: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4531/ : UNSTABLE

-------------------------------------
author: Zaid Mosley
date: 2015-02-13 16:53:14.000000000

Patch Set 6:

(1 comment)

Line:899, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> I prefer the pattern.

// only MTrimWindow have a trim 
if (!win instnace of ) {
 return;
}

-------------------------------------
author: Myah Faulkner
date: 2015-02-13 18:04:31.000000000

Patch Set 6:

(1 comment)

Line:899, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> I prefer the "single point of return" pattern. But you are co-lead. Do you want me to change the implementation to match your preferences or is it just a comment?

-------------------------------------
author: Zaid Mosley
date: 2015-02-16 11:48:43.000000000

Patch Set 6:

(1 comment)

Line:899, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> If you feel strong about this if statement we can leave it like it is. But if I look for example the adjustCTFButtons or isEmptyPerspectiveStack or maximize methods in this class, they seem to follow this pattern:

Check precondition and leave if not fufilled
Do stuff if precondition is fulfilled

So I think the method could be more consistent with the suggestion change. Please have a look at the class and tell me if you agree or if you prefer to have this change merged as it.

-------------------------------------
