DESCRIPTION

Workaround for potential java.util.ConcurrentModificationException

Change-Id: I4b2bbcf33cad25a866b8e1b4cf915e66e45bf581
Signed-off-by: Callie Donovan xxx@xxx.xxx

COMMENTS

author: Callie Donovan
date: 2015-01-24 18:17:25.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-01-24 18:17:30.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4282/

-------------------------------------
author: Brenden Conley
date: 2015-01-24 19:05:07.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4282/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-01-25 07:37:32.000000000

Patch Set 1: Code-Review-1

AFAICS we do not modify the list in the loop. Where do you see the modification?

-------------------------------------
author: Callie Donovan
date: 2015-01-25 07:57:52.000000000

Patch Set 1:

I've caught that exception while removing my view from the model when it is disposing xxx@xxx.xxx I'm doing that because I want all my views were automatically removed when my application is stopped.

java.util.ConcurrentModificationException
	at org.eclipse.emf.common.util.AbstractEList$EIterator.checkModCount(AbstractEList.java:758)
	at org.eclipse.emf.common.util.AbstractEList$EIterator.doNext(AbstractEList.java:706)
	at org.eclipse.emf.common.util.AbstractEList$EIterator.next(AbstractEList.java:692)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.safeRemoveGui(PartRenderingEngine.java:886)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.access$3(PartRenderingEngine.java:863)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$8.run(PartRenderingEngine.java:858)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.removeGui(PartRenderingEngine.java:842)
	at org.eclipse.e4.ui.workLeon Ochoach.renderers.swt.ElementReferenceRenderer.disposeWidget(ElementReferenceRenderer.java:118)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.safeRemoveGui(PartRenderingEngine.java:935)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.access$3(PartRenderingEngine.java:863)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$8.run(PartRenderingEngine.java:858)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.removeGui(PartRenderingEngine.java:842)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.safeRemoveGui(PartRenderingEngine.java:896)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.access$3(PartRenderingEngine.java:863)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$8.run(PartRenderingEngine.java:858)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.removeGui(PartRenderingEngine.java:842)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.safeRemoveGui(PartRenderingEngine.java:896)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.access$3(PartRenderingEngine.java:863)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$8.run(PartRenderingEngine.java:858)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.removeGui(PartRenderingEngine.java:842)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.safeRemoveGui(PartRenderingEngine.java:896)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.access$3(PartRenderingEngine.java:863)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$8.run(PartRenderingEngine.java:858)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.removeGui(PartRenderingEngine.java:842)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.safeRemoveGui(PartRenderingEngine.java:896)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.access$3(PartRenderingEngine.java:863)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$8.run(PartRenderingEngine.java:858)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.removeGui(PartRenderingEngine.java:842)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.hardClose(WorkbenchWindow.java:1937)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.busyClose(WorkbenchWindow.java:1560)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.access$15(WorkbenchWindow.java:1527)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow$10.run(WorkbenchWindow.java:1592)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.close(WorkbenchWindow.java:1589)
	at org.eclipse.ui.internal.WorkLeon Ochoach$14.run(Workbench.java:1155)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.WorkLeon Ochoach.busyClose(Workbench.java:1137)
	at org.eclipse.ui.internal.WorkLeon Ochoach.access$21(Workbench.java:1079)
	at org.eclipse.ui.internal.WorkLeon Ochoach$19.run(Workbench.java:1410)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkLeon Ochoach.close(Workbench.java:1407)
	at org.eclipse.ui.internal.WorkLeon Ochoach.close(Workbench.java:1380)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.busyClose(WorkbenchWindow.java:1556)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.access$15(WorkbenchWindow.java:1527)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow$10.run(WorkbenchWindow.java:1592)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.close(WorkbenchWindow.java:1589)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow.close(WorkbenchWindow.java:1603)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow$6.close(WorkbenchWindow.java:521)
	at org.eclipse.e4.ui.workLeon Ochoach.renderers.swt.WBWRenderer$11.shellClosed(WBWRenderer.java:564)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:98)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1085)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1070)
	at org.eclipse.swt.widgets.Decorations.closeWidget(Decorations.java:308)
	at org.eclipse.swt.widgets.Decorations.WM_CLOSE(Decorations.java:1696)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4612)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:339)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1626)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2075)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5023)
	at org.eclipse.swt.internal.win32.OS.DefWindowProcW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DefWindowProc(OS.java:2544)
	at org.eclipse.swt.widgets.Shell.callWindowProc(Shell.java:498)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4705)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:339)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1626)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2075)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5023)
	at org.eclipse.swt.internal.win32.OS.DefWindowProcW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DefWindowProc(OS.java:2544)
	at org.eclipse.swt.widgets.Shell.callWindowProc(Shell.java:498)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4705)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:339)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1626)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2075)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5023)
	at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2549)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3759)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1153)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.run(PartRenderingEngine.java:1034)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.E4Workbench.createAndRunUI(E4Workbench.java:148)
	at org.eclipse.ui.internal.WorkLeon Ochoach$5.run(Workbench.java:636)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.WorkLeon Ochoach.createAndRunWorkbench(Workbench.java:579)
	at org.eclipse.ui.PlatformUI.createAndRunWorkLeon Ochoach(PlatformUI.java:150)
	at ru.unislabs.pfr.orls.developer.application.DeveloperApplication.start(DeveloperApplication.java:52)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1438)

-------------------------------------
author: Zaid Mosley
date: 2015-01-26 11:13:36.000000000

Patch Set 1:

Can you open a bug report for this issue and attach a small example to it which demonstrates the problem?

-------------------------------------
author: Callie Donovan
date: 2015-01-26 13:43:20.000000000

Patch Set 1:

OK, I shall. Shall I attach link to this review?

-------------------------------------
author: Zaid Mosley
date: 2015-01-26 14:31:15.000000000

Patch Set 1:

The commit message should contain the bug number:

Bug xxxx - Bug description from Bugzilla

-------------------------------------
author: Callie Donovan
date: 2015-01-26 19:33:05.000000000

Patch Set 1:

Done. Bug 458460

-------------------------------------
