DESCRIPTION

Bug 458291 - [CSS] support styling exception with 'initial' properties 

Implementation and test cases for new CSS value 'inherit'

Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=458291
Change-Id: Iaaf50b56d4fa8524b66d54c2f6209f645da9a4eb
Signed-off-by: Clara Kelly xxx@xxx.xxx


COMMENTS

author: Clara Kelly
date: 2015-01-23 19:48:02.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-01-23 19:48:08.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4253/

-------------------------------------
author: Zaid Mosley
date: 2015-01-23 20:13:43.000000000

Patch Set 1:

(5 comments)

Looks good, minor comments inline

Line:28, tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CssSwtTestSuite.java -> Maybe use this opportunity to put every test case a separate line?

Line:9, /COMMIT_MSG -> Should this be "initial"?

Line:710, bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java -> Rewrite: In case of "initial" do not do any styling

Line:89, tests/org.eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/InitialTest.java -> Why do we have a line break here?

Line:120, tests/org.eclipse.e4.ui.tests.css.core/src/org/eclipse/e4/ui/tests/css/core/parser/InitialTest.java -> Why do we have a line break here?

-------------------------------------
author: Brenden Conley
date: 2015-01-23 20:35:57.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4253/ : SUCCESS

-------------------------------------
