DESCRIPTION

Bug 457211 - Clean up ToolBarManager

Fixed braces style, simplified deep nested if statements, removed
commented out code and unnecessary line breaks, etc.

Change-Id: I07135dfbbd0485a37f66d9821745bbdb62e1d509
Signed-off-by: Jayvion Booth xxx@xxx.xxx


COMMENTS

author: Jayvion Booth
date: 2015-01-11 19:00:33.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-01-11 19:00:39.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4079/

-------------------------------------
author: Brenden Conley
date: 2015-01-11 19:31:40.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4079/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-01-11 20:11:27.000000000

Patch Set 1: Code-Review-1

(9 comments)

I think the update method logic is not the same as before.

Line:2, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Adjust to 2014

Line:47, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Should fit in one line

Line:61, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Remove ws

Line:199, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Remove ws

Line:212, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Remove ws

Line:217, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Remove ws

Line:220, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Remove ws

Line:250, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> That is IMHO not the same as before.

isDirty= true
force = false

results in leaving this statement.

Line:397, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Remove ws

-------------------------------------
author: Jayvion Booth
date: 2015-01-11 21:47:53.000000000

Patch Set 1:

(1 comment)

I will fix whitespace.

Line:250, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Nope, the logic is exact same.

-------------------------------------
author: Jayvion Booth
date: 2015-01-11 22:20:27.000000000

Patch Set 1:

(7 comments)

Regarding the update method logic: it is *exactly* the same as before.

Line:47, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Nope. The automatic comment wrap is set to 80 characters.

Line:61, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Done

Line:199, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Done

Line:212, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Done

Line:217, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Done

Line:220, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Done

Line:397, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Done

-------------------------------------
author: Jayvion Booth
date: 2015-01-11 22:43:39.000000000

Patch Set 1:

(1 comment)

Line:2, bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java -> Done

-------------------------------------
