DESCRIPTION

Bug 383569 - [Contributions] [Perspectives] "Reset Perspective" does not
reset toolbar and menu contributions

Toolbars can be now disabled and enabled without affecting other
perspectives via CPD. Also reset perspective works fine for toolbars.

Change-Id: I72c96d2801d62e71e92080d67b2925c875c09980
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Jayvion Booth
date: 2015-01-11 19:34:08.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2015-01-11 20:04:20.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4081/

-------------------------------------
author: Zaid Mosley
date: 2015-01-11 20:18:42.000000000

Patch Set 4: Code-Review-1

I review tomorrow in detail but I would prefer that we use the IPresentation.HIDDEN_EXPLICITLY tag as we do for ToolControls. See ToolControlRenderer#ToolControlRenderer for hidding toolbars.

-------------------------------------
author: Brenden Conley
date: 2015-01-11 20:34:42.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4081/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2015-01-11 21:51:15.000000000

Patch Set 4:

Lars, I have no idea what did you mean by your last comment. Wrong review? I haven't introduced here anything new, it's just a fix of broken implementation.

-------------------------------------
author: Jayvion Booth
date: 2015-01-11 22:38:17.000000000

Patch Set 4:

BTW for the details about the fix see https://bugs.eclipse.org/bugs/show_bug.cgi?id=383569#c25

-------------------------------------
