DESCRIPTION

Bug 457198 - Cleanup CoolBarToTrimManager and ToolBarManagerRenderer

No behavioral changes are made, just code cleanup.

Replaced println() statements with IllegalStateException or
UnsupportedOperationException where appropriate. Removed commented out
debug statements, inconsistent braces style, unnecessary casts and line
breaks.

Change-Id: I35fe3e2c3e216ae25b94a4dbf81c31f974e540e2
Signed-off-by: Jayvion Booth xxx@xxx.xxx


COMMENTS

author: Jayvion Booth
date: 2015-01-10 23:51:27.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2015-01-10 23:51:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4072/

-------------------------------------
author: Brenden Conley
date: 2015-01-11 00:20:43.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4072/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-01-12 11:31:53.000000000

Patch Set 2:

(5 comments)

Thanks Andrey, looks good. ToolBarManagerRenderer has also a mixture of direct and annotation based event registration. I suggest to use this opportunity to clean that also up

Line:123, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Please convert this also to use annotations, similar to void xxx@xxx.xxx Event eventData)

Line:149, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Please convert this also to use annotations, similar to void xxx@xxx.xxx Event eventData)

Line:211, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Please convert this also to use annotations, similar to void xxx@xxx.xxx Event eventData)

Line:227, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Please convert this also to use annotations, similar to void xxx@xxx.xxx Event eventData)

Line:243, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Please convert this also to use annotations, similar to void xxx@xxx.xxx Event eventData)

-------------------------------------
author: Jayvion Booth
date: 2015-01-12 19:48:39.000000000

Patch Set 2:

(5 comments)

Line:123, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Done

Line:149, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Done

Line:211, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Done

Line:227, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Done

Line:243, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Done

-------------------------------------
