DESCRIPTION

Bug 455568 - [Min/Max] [Model] Add Special tag to allow Area Children to
be maximizable
https://bugs.eclipse.org/bugs/show_bug.cgi?id=455568

Added a special Tag "MaximizeableChildren" which allows the area to
behave as a mix of an Area and a PartSashContainer.

Change-Id: Id3ebd6ce4d5a9a2bf2c2640fecdf7e2f23799927
Signed-off-by: eneufeld xxx@xxx.xxx

COMMENTS

author: Makayla Callahan
date: 2015-03-27 11:48:11.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2015-03-27 12:28:07.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5197/

-------------------------------------
author: Brenden Conley
date: 2015-03-27 12:46:49.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5197/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-03-31 21:03:49.000000000

Patch Set 3:

(5 comments)

Sounds like an interesting idea — but it really needs some tests, and some stylistic practices need to be backed out (i.e., use of Class#isInstance() and Class#cast() is inconsistent with the rest of the code).

Have you thought about loosening the restriction from MArea to MGenericTile?  It would be nice to have a M1+M2+'M' that would progressively maximize a part within its PSC ancestry; it could be handy for the Debug perspective, for example.

Line:12, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> You need to add detail to the copyright

Line:120, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> This name doesn't convey the purpose of this method: what makes an element "valid"?  Perhaps hasVisibleContent()?

Line:722, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> ignoreTagChanges needs to be in a try/finally since the tag add or removal can trigger a lot of code.

Line:758, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> ignoreTagChanges needs to be in a try/finally since the tag add or removal can trigger a lot of code.

Line:966, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java -> ignoreTagChanges needs to be in a try/finally since the tag add or removal can trigger a lot of code.

-------------------------------------
author: Makayla Callahan
date: 2015-04-15 10:54:34.000000000

Patch Set 3:

I updated the patchset based on your comments.
I like the idea to create a generic solution. I would suggest to open a new bug for the more generic solution using the MGenericTile as it will require more time to get it right.

-------------------------------------
author: Gerrit Code Review
date: 2016-07-13 09:53:31.000000000

Change has been successfully merged into the git repository by Emma Robertson

-------------------------------------
