DESCRIPTION

Bug 455568 - [Min/Max] [Model] Add Special tag to allow Area Children to
be maximizable

Added a special Tag "MaximizeableChildren" which allows the area to
behave as a mix of an Area and a PartSashContainer.

Change-Id: Id3ebd6ce4d5a9a2bf2c2640fecdf7e2f23799927
Signed-off-by: Makayla Callahan xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-03-23 02:41:38.000000000

Patch Set 12:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8689/

-------------------------------------
author: Brenden Conley
date: 2016-03-23 03:10:35.000000000

Patch Set 12: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8689/ : SUCCESS

-------------------------------------
author: Emma Robertson
date: 2016-03-23 11:48:58.000000000

Patch Set 12: Code-Review+1

> (1 comment)
 > 
 > I spent a bit time looking through the patch.  I won't stand in the
 > way of this patch, but I found the original code confusing and
 > these changes don't improve it.
 > 
 > My confusion stems from that 'Maximizable Children' isn't really
 > documented anywhere.  Nor are the special cases that MinMaxAddon
 > has to handle — and how Maximizable Children changes those special
 > cases.  The special case handling code seems to be inserted
 > directly into the code, which makes it hard to reason about. 
 > Especially for whomever comes next to change the behaviour for
 > another piece.
 > 
 > I haven't actually tried running with the changes, but it seems to
 > me that there's a case that's not tested where a stack within the
 > MArea is minimized.  What happens if I switch perspectives?  That
 > minimized stack should be carried across, since the area is shared.

Hi Brian,

I think the new patch set addresses your comment, do you agree?

If so, I would accept this now...

-------------------------------------
author: Emma Robertson
date: 2016-03-28 08:16:15.000000000

Patch Set 13: Patch Set 12 was rebased

-------------------------------------
author: Gerrit Code Review
date: 2016-07-13 09:53:31.000000000

Change has been successfully merged into the git repository by Emma Robertson

-------------------------------------
