DESCRIPTION

Bug 420956 - Fix perspective customization on 4.x

The CustomizePerspectiveDialog shows now all toolbar/menubar
contributions from action sets (with right labels) previously shown in
3.x stream, allows disable/enable button status per perspective
and persist the state in the model. Additionally the label provider is
enhanced to show the availability of almost all contribution depending
on the action set state.

Note: disabling and re-enabling entire toolbars is still broken as
described in bug 383569 comment 24 and will be fixed in the next
patches.

Change-Id: I6f002c518e671437775187ffcc6c51050aa8e0ae
Signed-off-by: Jayvion Booth xxx@xxx.xxx
Also-by: Heath Gonzalez xxx@xxx.xxx
Also-by: Slade Moran xxx@xxx.xxx
Also-by: Jaydon Logan xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2015-01-23 12:21:05.000000000

Patch Set 21:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4246/

-------------------------------------
author: Brenden Conley
date: 2015-01-23 13:08:03.000000000

Patch Set 21: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4246/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2015-01-23 14:51:12.000000000

Patch Set 21: Code-Review+2

(3 comments)

Line:151, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Can this move closer to the end of this method?  The app remove can happen after the shell is disposed since it's TBR is already false.

Line:40, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Why can't this take the display from the instantiating class, the CPD?  You can't use Display.getDefault() in the workbench, it doesn't always return the correct value.

Line:621, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> Please add a comment that this section should match what's in org.eclipse.e4.ui.workbench.renderers.swt.ToolBarManagerRenderer.processHandledItem(ToolBarManager, MHandledToolItem)

-------------------------------------
author: Slade Moran
date: 2015-01-23 14:52:34.000000000

Patch Set 21: Code-Review+1

I think it looks good, I'd like to get it in so we can move onto the next set of patches.  I have 3 comments, but only one is an absolute must fix (the display.getCurrent()).

-------------------------------------
author: Jayvion Booth
date: 2015-01-23 21:11:23.000000000

Patch Set 21:

(3 comments)

Next patchset will contain fixes below.

Line:151, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:40, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Done, I'm using now PlatformUI.getWorkbench().getDisplay();
I think this is OK?

Line:621, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> Done

-------------------------------------
