DESCRIPTION

Bug 420956 - Fix perspective customization on 4.x

The CustomizePerspectiveDialog shows now all toolbar/menubar
contributions from action sets (with right labels) previously shown in
3.x stream, allows disable/enable button status per perspective
and persist the state in the model. Additionally the label provider is
enhanced to show the availability of almost all contribution depending
on the action set state.

Note: disabling and re-enabling entire toolbars is still broken as
described in bug 383569 comment 24 and will be fixed in the next
patches.

Change-Id: I6f002c518e671437775187ffcc6c51050aa8e0ae
Signed-off-by: Jayvion Booth xxx@xxx.xxx
Also-by: Heath Gonzalez xxx@xxx.xxx
Also-by: Slade Moran xxx@xxx.xxx
Also-by: Jaydon Logan xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2015-01-13 13:05:48.000000000

Patch Set 15:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4106/

-------------------------------------
author: Brenden Conley
date: 2015-01-13 13:40:47.000000000

Patch Set 15: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4106/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-01-13 19:15:54.000000000

Patch Set 15:

(7 comments)

Looks fine to me and my tests were fine. While we wait for Paul to review this again, I have some small improvement suggestions.

Line:52, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Maybe better to use default access modifier and final, like in the other classes, e.g., FilterModelCheckListener.

Line:57, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> This is a way better description than the Javadoc above. I created https://bugs.eclipse.org/bugs/show_bug.cgi?id=457354 to update the class Javadoc with a better description.

Line:78, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Maybe better to use default access modifier, like in the other classes, e.g., FilterModelCheckListener.

Line:92, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Minor thing: eclipseContext.set(MWindow.class, windowModel); should be sufficient

Line:165, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> I don't think this hurts but line 96 already sets this window.tbr to false and I have not seen that this property has changed.

Line:524, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java -> Silly think but can we call this workbenchPage, wPage and Ctrl+K lands frequently on the method sho(wPage) and I like to use Ctrl+K to follow a variable

Line:1629, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java -> Enhanced for loop?

-------------------------------------
author: Jayvion Booth
date: 2015-01-13 20:09:50.000000000

Patch Set 15:

(7 comments)

Line:52, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:57, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:78, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:92, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:165, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:524, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java -> Done

Line:1629, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java -> Done

-------------------------------------
