DESCRIPTION

Move CustomizePerspectiveDialog and TreeManager to "cpd" package

CustomizePerspectiveDialog is too huge to be maintainable.
Moved the dialog class (and TreeManager) to the new "cpd" package, moved
all not necessary inner classes out of the dialog class, cleaned up
warnings, code.

Change-Id: Ib0e2e887d3c780e4041ad97553fba8cbfc2a6764
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Jayvion Booth
date: 2014-12-29 10:30:25.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-12-29 10:30:31.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3955/

-------------------------------------
author: Brenden Conley
date: 2014-12-29 10:50:12.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3955/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-01-05 17:04:29.000000000

Patch Set 2: Code-Review-1

(13 comments)

Awesome Andrey, thanks a lot, this cleanup looks like a lot of work.

 Looks to me that our default formatter was incorrectly configured, this should be fixed in master. Can you rebase onto master and reformat your new classes. Also please review my comments.

Line:25, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ShortcutLabelProvider.java -> Do you need TreeManager.TreeItemLabelProvider here? Looks like you only implement ITableLabelProvider

Line:79, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/UnavailableContributionItemCheckListener.java -> I have a hard time spotting the difference to the code in the above if clause. Can you move the common part before the if (viewer.getExpandedState()) statement.

Line:26, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ActionSetSelectionChangedListener.java -> I would avoid the line break, we use 120 line lenght as new default in Eclipse 4.5. I ensured to set this for the plug-in, please reformat the source code.

Line:38, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ActionSetSelectionChangedListener.java -> You can use getStructuredSelection() in Eclipse 4.5

Line:38, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> I think this fits into one line with the 120 setting

Line:82, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> What is the purpose of a method which always returns null? Maybe better to throw an UnSupportOperationException?

Line:123, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Put in one line

Line:7, /COMMIT_MSG -> Please use platform commit message

Line:33, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Remove line break

Line:65, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Remove line break

Line:67, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Should also fit in one line

Line:29, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/FilteredViewerCheckListener.java -> Remove line break

Line:25, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/FilteredTreeCheckProvider.java -> Remove line break

-------------------------------------
author: Jayvion Booth
date: 2015-01-06 00:19:44.000000000

Patch Set 2:

(13 comments)

Line:25, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ShortcutLabelProvider.java -> Yes, getImage() and getText() are implemented in the TreeItemLabelProvider

Line:79, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/UnavailableContributionItemCheckListener.java -> The code is taken 1:1 from the CPD. I have no idea why if/else branches are same and what the original author wanted to say here and so I have no idea which branch should be eliminated.

Line:26, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ActionSetSelectionChangedListener.java -> Done

Line:38, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ActionSetSelectionChangedListener.java -> There is no such API in SelectionChangedEvent in 4.5 *I* use (M4 + few commits on top).

Line:38, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:82, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> There is code which calls this method but does not uses the result. See Page class for example... My intent was not to introduce *any new* behavior while trying to fix CPD, to make sure I don't brake something unintentionally.

Line:123, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizeActionBars.java -> Done

Line:7, /COMMIT_MSG -> Done

Line:33, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Done

Line:65, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Done

Line:67, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/GrayOutUnavailableLabelProvider.java -> Done

Line:29, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/FilteredViewerCheckListener.java -> Done

Line:25, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/FilteredTreeCheckProvider.java -> Done

-------------------------------------
