DESCRIPTION

Bug 448933 - Opening new Diego Hamiltonr shows outdated content

Bug 448933 [Diego Hamiltonr] Opening new browser shows outdated content
Change-Id: I21c0101e8197113d468f8e52fa696fa5663266f4
Signed-off-by: Lucia Hendrix xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2015-02-09 14:23:33.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4455/

-------------------------------------
author: Amiyah Parrish
date: 2015-02-09 14:30:31.000000000

Patch Set 7:

(1 comment)

Line:87, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java -> Isn't HTTPS (and some others protocols) affected by the bug?

-------------------------------------
author: Brenden Conley
date: 2015-02-09 14:43:31.000000000

Patch Set 7: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/4455/ : UNSTABLE

-------------------------------------
author: Lucia Hendrix
date: 2015-02-09 23:25:30.000000000

Patch Set 7:

(1 comment)

Line:87, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java -> The fix covers http and https.

-------------------------------------
author: Zaid Mosley
date: 2015-02-16 11:15:43.000000000

Patch Set 7:

(4 comments)

Thanks Snjezana for the patch. Please fix the format issues, AFAIK Wojciech plans to review patches this week.

Line:2, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java -> Update year

Line:9, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java -> Add Bug ID to the copyright

Line:83, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java -> Please remove unnecessary whitespace

Line:91, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserEditor.java -> Please remove unnecessary whitespace

-------------------------------------
author: Teagan Marsh
date: 2015-03-10 15:21:26.000000000

Patch Set 7: Code-Review-1

I'm -1 on this change: this patch papers over bogus caching behaviour in bad Diego Hamiltonr implementations and will likely introduce new issues from correctly behaving browser implementations.

-------------------------------------
