DESCRIPTION

Bug 432480: Show workspace location in pref page and window title

- Show the true workspace location in the Workspace preference page.
- Add an option to show the workspace location in the window title.
  Support the -showlocation command line switch such that UI toggle is
  disabled if it is specified, and show the specified location from the
  command line in addition, if this one differs from the workspace 
  location.  This is why we call the UI text "Show location" instead of
  "Show workspace location".

Change-Id: Ica1e2186ed3aafbcec1bb5a35c0b07394771029b
Signed-off-by: Braedon Velazquez xxx@xxx.xxx

COMMENTS

author: Braedon Velazquez
date: 2014-12-03 16:31:25.000000000

Uploaded patch set 2.

-------------------------------------
author: Zaid Mosley
date: 2014-12-03 16:59:58.000000000

Patch Set 2: Code-Review-1

(1 comment)

Thanks Christian for the patch. I suggest to tried the command line parameter similar to the perspective with you can define in the command line, see E4Application.

String forcedPerspectiveId = getArgValue(PERSPECTIVE_ARG_NAME, applicationContext, false);
		if (forcedPerspectiveId != null) {
			appContext.set(E4WorkLeon Ochoach.FORCED_PERSPECTIVE_ID, forcedPerspectiveId);
		}
This keeps the parsing of the command line out of the preference page, and we can store it transient in the IEclipseContext.

What do you think?

Line:612, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java -> I don't like this logic here. Why not parse the parameter in E4Application and put in

-------------------------------------
author: Brenden Conley
date: 2014-12-03 17:01:50.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3848/

-------------------------------------
author: Brenden Conley
date: 2014-12-03 17:34:23.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3848/ : SUCCESS

-------------------------------------
author: Braedon Velazquez
date: 2014-12-04 14:22:49.000000000

Patch Set 2:

(1 comment)

Line:612, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java -> Done.  This requires a bit more brains in getArgValue() to handle an optional arg value, whose name has to be compared ignoring case.

Also note the new bundle dependencies to e4 in the upcoming patchset.

-------------------------------------
