DESCRIPTION

Bug 451687: - Executing EarlyStartup extensions in parallel using JobGroup API.

Signed-off-by: Virginia Riley xxx@xxx.xxx


COMMENTS

author: Virginia Riley
date: 2014-12-02 02:22:36.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-12-02 02:22:42.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3840/

-------------------------------------
author: Brenden Conley
date: 2014-12-02 02:54:41.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3840/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2014-12-02 04:08:01.000000000

Patch Set 1:

(3 comments)

Line:2805, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> This line is probably unnecessary since job creation is very fast.

Line:2807, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> stattup -> startup

Line:2817, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Consider creating a named nested class EarlyStartupJob to avoid repeating the belongsTo method and lines 2822-2823.

-------------------------------------
author: Zaid Mosley
date: 2014-12-02 12:56:41.000000000

Patch Set 1:

Thirumala, please adjust the code as suggested by Sergey.

-------------------------------------
author: Brock Pruitt
date: 2014-12-02 15:28:54.000000000

Patch Set 1:

(1 comment)

Line:2788, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> If we assume that early startup is a 50-50 mixture of CPU and IO, the concurrency level should be numProcessors * 2.

-------------------------------------
author: Zaid Mosley
date: 2014-12-02 15:36:22.000000000

Patch Set 1:

(1 comment)

Line:2788, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Nice to hear that, I was thinking the same, but didn't dare to suggest it. :-) +1

-------------------------------------
author: Virginia Riley
date: 2014-12-02 20:58:57.000000000

Patch Set 1:

(5 comments)

Thanks Sergey and Lars. Please take another look.

Line:2788, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Done

Line:2788, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Done

Line:2805, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Done

Line:2807, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Done

Line:2817, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Done

-------------------------------------
