DESCRIPTION

Bug 432498 - [Trim] Fast views get created on start-up

Change-Id: I7338127b68ded8b9d644e3548d64bc765b670e04
Signed-off-by: Addison Irwin xxx@xxx.xxx


COMMENTS

author: Addison Irwin
date: 2014-11-20 16:25:16.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-11-20 16:25:22.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3796/

-------------------------------------
author: Brenden Conley
date: 2014-11-20 17:04:02.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3796/ : FAILURE

-------------------------------------
author: Sebastian Porter
date: 2014-11-25 14:46:39.000000000

Patch Set 4: Verified+1

(3 comments)

The bundle version of 'org.eclipse.e4.ui.workLeon Ochoach.addons.swt' must be increased.

Line:151, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Is this changes really necessary for that bug fix?

Line:952, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/TrimStack.java -> This looks wrong to me.

Line:204, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java -> This is not an English sentence.
Javadoc should end with a dot.

-------------------------------------
author: Sebastian Porter
date: 2014-11-25 14:48:42.000000000

Patch Set 4:

There's also the string "active" used here:

org.eclipse.e4.ui.css.swt.dom.ShellElement.isPseudoInstanceOf(String)

Please check whether this relates to our new constant.

-------------------------------------
author: Addison Irwin
date: 2014-11-25 15:08:56.000000000

Patch Set 4:

(2 comments)

Line:151, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Yes, it is needed

Line:952, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/TrimStack.java -> It is old code. I refactored it a bit in order to avoid double casting to CTabFolder. 
Unfortunately we need the hack below

-------------------------------------
author: Sebastian Porter
date: 2014-11-25 15:31:30.000000000

Patch Set 4: Verified-1

(2 comments)

Actually the patch introduces a severe issue: follow the steps from https://bugs.eclipse.org/bugs/show_bug.cgi?id=432498#c3, good: it doesn't create the view. Now click on the 'Restore' button of the minimized stack ==> it does not create the Javadoc view!

Line:151, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java -> Well, I replaced it with the old code and the fix does the same.

Plus: the new field produces a warning since it hides the inherited protected field from AbstractPartRenderer.

Line:952, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/TrimStack.java -> Look at the code again please. What you really want to test here is 'ctf'.

-------------------------------------
author: Addison Irwin
date: 2014-11-25 16:13:38.000000000

Patch Set 4:

>  it doesn't create the view. Now click on the 'Restore' button of the minimized stack ==> it does not create the Javadoc view!

This view doesn't work correctly without the patch as well. So I think it should get fixed with separate bug. I will apply other comments and prepare update of the patch

Daniel

-------------------------------------
author: Sebastian Porter
date: 2014-11-26 09:20:50.000000000

Patch Set 4:

No that is not true:

1. start your dev workspace with plain R4_4_maintenance code
2. do steps from comment 3
3. click the 'Restore' button on the minimized stack
==> Javadoc view is there and working

OR use eclipse-SDK-M20141112-0800-win32-x86_64 and do the same steps to see that the Javadoc view works fine.

-------------------------------------
