DESCRIPTION

Bug 450219 - [Monitoring] Don't log stack traces of non-interesting
threads

Change-Id: I07e3bbf9a5907bd8bcb8c6da69401ec47990287e
Signed-off-by: Brock Pruitt xxx@xxx.xxx


COMMENTS

author: Brock Pruitt
date: 2014-11-06 23:25:32.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-11-07 09:25:19.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3686/

-------------------------------------
author: Brenden Conley
date: 2014-11-07 10:11:40.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3686/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-11-11 08:47:39.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:664, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/EventLoopMonitorThread.java -> Why don't we handle that via the Filter? I dislike having a special treatment of certain stacktraces. I think it is OK to add them to the filter (with wildcards) but hard-coding them, seems wrong.

-------------------------------------
author: Brock Pruitt
date: 2014-11-11 15:12:01.000000000

Patch Set 1:

(1 comment)

Line:664, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/EventLoopMonitorThread.java -> The filter doesn't support wildcards. Adding full wildcard support (as opposed to class prefix only) to the filter class would be a major effort.

-------------------------------------
author: Zaid Mosley
date: 2014-11-11 19:19:09.000000000

Patch Set 1:

Class prefix is the only thing needed here, as it seems from the code

if (!className.startsWith("java.") && !className.startsWith("sun.") &&

-------------------------------------
