DESCRIPTION

Bug 450187 - IPresentationEngine should contain constants for View and
Editor tags

Change-Id: Idc4b19af9b4a68c9c2adb2e616eabf2878227b8d
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2014-11-05 22:37:16.000000000

Uploaded patch set 5.

-------------------------------------
author: Zaid Mosley
date: 2014-11-05 22:40:32.000000000

Patch Set 5:

(1 comment)

Line:97, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewContentProvider.java -> IMHO more logical is tag.equals(...) as before

-------------------------------------
author: Krista Shepherd
date: 2014-11-05 22:50:24.000000000

Patch Set 5:

(1 comment)

Line:97, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewContentProvider.java -> IMHO it is good practise to always use the constant's equals method as variables may be null and therefore may cause a NPE.

-------------------------------------
author: Zaid Mosley
date: 2014-11-05 23:05:22.000000000

Patch Set 5: Code-Review+2 Verified+1

(2 comments)

Line:97, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewContentProvider.java -> Done

Line:97, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewContentProvider.java -> Done

-------------------------------------
author: Zaid Mosley
date: 2014-11-05 23:06:11.000000000

Patch Set 5:

Dani, this looks good to me (constants as API instead of Strings) for the View and Editor tag. Any concerns from you?

-------------------------------------
author: Brenden Conley
date: 2014-11-06 04:52:23.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3652/

-------------------------------------
author: Brenden Conley
date: 2014-11-06 05:57:27.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3652/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-11-06 21:01:32.000000000

Patch Set 5: Code-Review-2

I realized that the IWorkLeon OchoachRegistryConstants contains constants for views and editors. I suggest we reuse them. Unfortunately they define the tag as "view" and "editor" and not "View" and "Editor", but it still makes sense to use these internal constants.

-------------------------------------
author: Zaid Mosley
date: 2014-11-06 21:19:27.000000000

Abandoned

See Bug

-------------------------------------
