DESCRIPTION

Bug 450187 - IPresentationEngine should contain constants for View and
Editor tags

Change-Id: Idc4b19af9b4a68c9c2adb2e616eabf2878227b8d
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2014-11-05 21:42:33.000000000

Uploaded patch set 3.

-------------------------------------
author: Zaid Mosley
date: 2014-11-05 22:08:53.000000000

Patch Set 3: Code-Review-1

Lots of unrelated whitespace change. We should not mix content and wc changes. I suggest you open a bug for org.eclipse.e4.ui.workLeon Ochoach to solve the whitespace issues seperately.

-------------------------------------
author: Zaid Mosley
date: 2014-11-05 22:13:00.000000000

Patch Set 3:

(2 comments)

Line:1969, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/Workbench.java -> Can you also assign a name to the descriptor. Kills me in debugging that the editor name is null.

Line:230, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java -> Please follow the convention of the other tags description.

 This tag can be applied to an element (usually an MPart) to indicate that the element should be handled as view.

Same for editor, please lower lower cases for editor.

-------------------------------------
author: Brenden Conley
date: 2014-11-05 23:22:09.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3644/

-------------------------------------
author: Brenden Conley
date: 2014-11-06 00:05:27.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3644/ : SUCCESS

-------------------------------------
